On Thu, Jul 16, 2015 at 04:40:03PM -0400, Waiman Long wrote:
> On 07/16/2015 11:32 AM, Will Deacon wrote:
> >@@ -117,6 +115,8 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
> > #error "SMP is not supported on this platform"
^^^^^^^^^^^^^
> > #endif
> >
> >+#define xchg xchg_relaxed
>
> Is that a typo? I think xchg() needs to be a full memory barrier.
Pointless on UP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
> On 07/16/2015 11:32 AM, Will Deacon wrote:
> >@@ -117,6 +115,8 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
> > #error "SMP is not supported on this platform"
^^^^^^^^^^^^^
> > #endif
> >
> >+#define xchg xchg_relaxed
>
> Is that a typo? I think xchg() needs to be a full memory barrier.
Pointless on UP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/