Re: [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces

Peter Zijlstra [peterz@infradead.org] wrote:
| On Tue, Jul 14, 2015 at 08:01:50PM -0700, Sukadev Bhattiprolu wrote:
| > @@ -1604,6 +1613,12 @@ static void power_pmu_start_txn(struct pmu *pmu)
| > static void power_pmu_cancel_txn(struct pmu *pmu)
| > {
| > struct cpu_hw_events *cpuhw = this_cpu_ptr(&cpu_hw_events);
| > + int txn_flags;
| > +
| > + txn_flags = cpuhw->txn_flags;
| > + cpuhw->txn_flags = 0;
| > + if (cpuhw->txn_flags & ~PERF_PMU_TXN_ADD)
| > + return;
|
| That seems, unintentional? ;-)

Argh. Thanks for catching it.

Sukadev


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/