On Mon, 2015-07-20 at 20:55 -0400, Steven Rostedt wrote:
> On Fri, 17 Jul 2015 15:37:54 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > > + if ($line =~ /\b(synchronize_rcu_expedited|synchronize_sched_expedited)\(/) {
> >
> > It'd be faster perl without capture groups:
>
> Is checkpatch such a critical code path that we could possibly notice
> the difference in speed? Although the above may be few microseconds
> slower, to me, the above looks a hell of a lot more readable.
Regardless, it's not as capable as it wouldn't find
any miswritten form like
synchronize_<foo>_expedited ( args... )
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
> On Fri, 17 Jul 2015 15:37:54 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > > + if ($line =~ /\b(synchronize_rcu_expedited|synchronize_sched_expedited)\(/) {
> >
> > It'd be faster perl without capture groups:
>
> Is checkpatch such a critical code path that we could possibly notice
> the difference in speed? Although the above may be few microseconds
> slower, to me, the above looks a hell of a lot more readable.
Regardless, it's not as capable as it wouldn't find
any miswritten form like
synchronize_<foo>_expedited ( args... )
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/