[PHP-DEV] Re: [DOC-CVS] svn: /phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml

On 14.08.2015 at 17:18, Peter Cowburn wrote:

> On 14 August 2015 at 13:49, Christoph Michael Becker <cmb@php.net> wrote:
>
>> cmb Fri, 14 Aug 2015 12:49:32 +0000
>>
>> Revision: http://svn.php.net/viewvc?view=revision&revision=337451
>>
>> Log:
>> fixed wrong parameter name (Reflection!) (fixes #70265)
>>
>
> I'd *much* rather see this changed in php-src so that reflection gives a
> more useful name. Changing the parameter name from "timezone" to "object"
> is a step backwards.

I agree, but changing the parameter name in php-src would introduce a BC
break. Maybe something to consider for PHP 7 only?

>> Bug: https://bugs.php.net/70265 (Verified) Wrong name of
>> DateTimeImmutable::__construct's 2nd param
>>
>> Changed paths:
>> U phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
>>
>> Modified:
>> phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
>> ===================================================================
>> --- phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
>> 2015-08-14 11:39:59 UTC (rev 337450)
>> +++ phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
>> 2015-08-14 12:49:32 UTC (rev 337451)
>> @@ -14,13 +14,13 @@
>> <constructorsynopsis role="oop">
>> <modifier>public</modifier>
>> <methodname>DateTimeImmutable::__construct</methodname>
>> <methodparam
>> choice="opt"><type>string</type><parameter>time</parameter><initializer>"now"</initializer></methodparam>
>> - <methodparam
>> choice="opt"><type>DateTimeZone</type><parameter>timezone</parameter><initializer>&null;</initializer></methodparam>
>> + <methodparam
>> choice="opt"><type>DateTimeZone</type><parameter>object</parameter><initializer>&null;</initializer></methodparam>
>> </constructorsynopsis>
>> <para>&style.procedural;</para>
>> <methodsynopsis role="procedural">
>>
>> <type>DateTimeImmutable</type><methodname>date_create_immutable</methodname>
>> <methodparam
>> choice="opt"><type>string</type><parameter>time</parameter><initializer>"now"</initializer></methodparam>
>> - <methodparam
>> choice="opt"><type>DateTimeZone</type><parameter>timezone</parameter><initializer>&null;</initializer></methodparam>
>> + <methodparam
>> choice="opt"><type>DateTimeZone</type><parameter>object</parameter><initializer>&null;</initializer></methodparam>
>> </methodsynopsis>
>> <para>
>> Like <methodname>DateTime::__construct</methodname> but works with

--
Christoph M. Becker


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php