Re: [PATCH 1/3] mmc: debugfs: fix memory leak for mmc_ext_csd_open

On 2015/9/22 9:29, trick wong wrote:
> In the correct path,this buf will used later.why freed?
>

right.
sorry for this noise, withdraw this patch[1/3].

> 2015-09-22 9:18 GMT+08:00 Shawn Lin <shawn.lin@rock-chips.com
> <mailto:shawn.lin@rock-chips.com>>:
>
> buf allocated isn't been freed before return, so we fix it.
>
> Fixes: 736bb6bb01a ("mmc: Add Extended CSD register to debugfs")
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com
> <mailto:shawn.lin@rock-chips.com>>
> ---
>
> drivers/mmc/core/debugfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index e914210..b2ab936 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -304,6 +304,7 @@ static int mmc_ext_csd_open(struct inode *inode,
> struct file *filp)
>
> filp->private_data = buf;
> kfree(ext_csd);
> + kfree(buf);
> return 0;
>
> out_free:
> --
> 2.3.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>


--
Best Regards
Shawn Lin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/