Re: [PATCH] libata: add support for NCQ commands for SG interface

On 10/17/2015 3:25 PM, Vinayak Kale wrote:

>>> From: Vinayak Kale <vinayak.kale@seagate.com>
>>>
>>> This patch is needed to make NCQ commands with FPDMA protocol value
>>> (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface.
>>>
>>> Signed-off-by: Vinayak Kale <vinayak.kale@seagate.com>
>>> ---
>>> drivers/ata/libata-scsi.c | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
>>> index 0d7f0da..5b0a5ab 100644
>>> --- a/drivers/ata/libata-scsi.c
>>> +++ b/drivers/ata/libata-scsi.c
>>
>> [...]
>>>
>>> @@ -2963,7 +2965,7 @@ static unsigned int ata_scsi_pass_thru(struct
>>> ata_queued_cmd *qc)
>>> tf->hob_lbal = cdb[7];
>>> tf->hob_lbam = cdb[9];
>>> tf->hob_lbah = cdb[11];
>>> - tf->flags |= ATA_TFLAG_LBA48;
>>> + tf->flags |= (ATA_TFLAG_LBA48 | ATA_TFLAG_LBA);
>>
>>
>> Parens not needed here.
> That's quite neat :-) Thanks, will change it in V2.

Looking at this hunk again, it seems an unrelated change.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/